From 272ab46e17f7e9ae1e1c64bd3e5d4120de4baae5 Mon Sep 17 00:00:00 2001 From: Sam Curry Date: Thu, 21 May 2026 17:26:03 +0800 Subject: [PATCH 1/3] fix: handle the auth reply URL having error state (currently swallowed) --- package.json | 2 +- src/index.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 4e6aaab..8b1ad7b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@makerx/express-msal", - "version": "2.0.0", + "version": "2.0.1", "private": false, "description": "An express middleware for PKCE via Microsoft Authentication Library for Node (MSAL Node).", "author": "MakerX", diff --git a/src/index.ts b/src/index.ts index 1bdc8a8..97ef11f 100644 --- a/src/index.ts +++ b/src/index.ts @@ -114,6 +114,11 @@ const createAuthHandler = ({ msalClient, scopes, authReplyRoute, augmentSession, pkceCodes: { verifier }, } = req.session + if (req.query.error) { + logger?.error('Error returned in auth reply query parameters', { error: req.query.error, query: req.query }) + throw new Error(req.query.error as string, { cause: req.query }) + } + const tokenRequest: AuthorizationCodeRequest = { code: req.query.code as string, scopes, From d0b2f5be567c02d9336733f44618ae31fc655700 Mon Sep 17 00:00:00 2001 From: Sam Curry Date: Thu, 21 May 2026 17:32:41 +0800 Subject: [PATCH 2/3] adjust --- src/index.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/index.ts b/src/index.ts index 97ef11f..835165e 100644 --- a/src/index.ts +++ b/src/index.ts @@ -115,8 +115,9 @@ const createAuthHandler = ({ msalClient, scopes, authReplyRoute, augmentSession, } = req.session if (req.query.error) { - logger?.error('Error returned in auth reply query parameters', { error: req.query.error, query: req.query }) - throw new Error(req.query.error as string, { cause: req.query }) + const details = { error: req.query.error, error_description: req.query.error_description } + logger?.error('Error returned in auth reply query parameters', details) + throw new Error(req.query.error as string, { cause: details }) } const tokenRequest: AuthorizationCodeRequest = { From 643c1c76950495ebb96ea56911a238245a638098 Mon Sep 17 00:00:00 2001 From: Sam Curry Date: Thu, 21 May 2026 17:33:16 +0800 Subject: [PATCH 3/3] npm audit fix --- package-lock.json | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/package-lock.json b/package-lock.json index ae7b198..e8bc3d8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@makerx/express-msal", - "version": "2.0.0", + "version": "2.0.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@makerx/express-msal", - "version": "2.0.0", + "version": "2.0.1", "license": "MIT", "devDependencies": { "@arethetypeswrong/cli": "0.18.2", @@ -2177,9 +2177,9 @@ } }, "node_modules/@typescript-eslint/typescript-estree/node_modules/brace-expansion": { - "version": "5.0.5", - "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-5.0.5.tgz", - "integrity": "sha512-VZznLgtwhn+Mact9tfiwx64fA9erHH/MCXEUfB/0bX/6Fz6ny5EGTXYltMocqg4xFAQZtnO3DHWWXi8RiuN7cQ==", + "version": "5.0.6", + "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-5.0.6.tgz", + "integrity": "sha512-kLpxurY4Z4r9sgMsyG0Z9uzsBlgiU/EFKhj/h91/8yHu0edo7XuixOIH3VcJ8kkxs6/jPzoI6U9Vj3WqbMQ94g==", "dev": true, "license": "MIT", "dependencies": { @@ -3932,9 +3932,9 @@ "license": "MIT" }, "node_modules/fast-uri": { - "version": "3.1.0", - "resolved": "https://registry.npmjs.org/fast-uri/-/fast-uri-3.1.0.tgz", - "integrity": "sha512-iPeeDKJSWf4IEOasVVrknXpaBV0IApz/gp7S2bb7Z4Lljbl2MGJRqInZiUrQwV16cpzw/D3S5j5Julj/gT52AA==", + "version": "3.1.2", + "resolved": "https://registry.npmjs.org/fast-uri/-/fast-uri-3.1.2.tgz", + "integrity": "sha512-rVjf7ArG3LTk+FS6Yw81V1DLuZl1bRbNrev6Tmd/9RaroeeRRJhAt7jg/6YFxbvAQXUCavSoZhPPj6oOx+5KjQ==", "dev": true, "funding": [ { @@ -6759,9 +6759,9 @@ } }, "node_modules/rimraf/node_modules/brace-expansion": { - "version": "5.0.5", - "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-5.0.5.tgz", - "integrity": "sha512-VZznLgtwhn+Mact9tfiwx64fA9erHH/MCXEUfB/0bX/6Fz6ny5EGTXYltMocqg4xFAQZtnO3DHWWXi8RiuN7cQ==", + "version": "5.0.6", + "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-5.0.6.tgz", + "integrity": "sha512-kLpxurY4Z4r9sgMsyG0Z9uzsBlgiU/EFKhj/h91/8yHu0edo7XuixOIH3VcJ8kkxs6/jPzoI6U9Vj3WqbMQ94g==", "dev": true, "license": "MIT", "dependencies": {