Skip to content

Commit f2bb263

Browse files
Prototype AuthorCopilot
andcommitted
fix(hub): audit safe decision previews
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 6e27e53 commit f2bb263

4 files changed

Lines changed: 35 additions & 2 deletions

File tree

‎hub/server/domains/decision-model/create-hub-decision-taskset-source/index.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,7 @@ describe("createHubDecisionTasksetSource()", () => {
590590
{ viewport: "narrow", theme: "light" },
591591
{ viewport: "narrow", theme: "dark" },
592592
])
593+
expect(prepared.state.imagesNote).not.toContain(prepared.route)
593594
expect(prepared.images).toHaveLength(4)
594595
expect(prepared.questionDigest).toMatch(/^sha256:[0-9a-f]{64}$/)
595596
expect(prepared.screenshotSetDigest).toMatch(/^sha256:[0-9a-f]{64}$/)

‎hub/server/domains/decision-model/create-hub-decision-taskset-source/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -921,7 +921,7 @@ export function createHubDecisionTasksetSource(options: HubDecisionTasksetSource
921921
imagesNote: screenshots
922922
.map(
923923
(screenshot, index) =>
924-
`Image ${index + 1} is route ${JSON.stringify(screenshot.route)} at ${screenshot.viewport.width} by ${screenshot.viewport.height} or taller in ${screenshot.theme} theme.`,
924+
`Image ${index + 1} is ${screenshot.viewport.width} by ${screenshot.viewport.height} or taller in ${screenshot.theme} theme.`,
925925
)
926926
.join(" "),
927927
},

‎packages/learning/src/store.mjs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2510,7 +2510,12 @@ class LearningStore {
25102510
],
25112511
})
25122512
assertValid("exportManifest", manifest)
2513-
if (!preview)
2513+
if (preview)
2514+
await this.#audit(context, "export.create", [], {
2515+
purpose,
2516+
reason: `Previewed ephemeral export ${manifest.id} with digest ${manifest.digest}.`,
2517+
})
2518+
else
25142519
await this.#append(
25152520
"exports",
25162521
[manifest],

‎packages/learning/test/export-manifest-compatibility.test.mjs‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,33 @@ function providerThatStoresHistoricalExports() {
4444
}
4545

4646
describe("historical export manifests", () => {
47+
it("audits preview exports without retaining them as deletion follow-ups", async () => {
48+
const provider = createInMemoryProvider()
49+
const store = await createLearningStore({ provider, clock: () => NOW })
50+
const grant = await store.addGrant(PERSON, {
51+
purposes: ["review"],
52+
sources: ["hub_review_comments"],
53+
basis: "The team agreed to review its Hub comments.",
54+
})
55+
await store.importHubReviewComments(AGENT, weekOneLog(), { grantIds: [grant.id] })
56+
57+
const preview = await store.exportRecords(PERSON, {
58+
purpose: "review",
59+
destination: "/tmp/ephemeral-review.json",
60+
preview: true,
61+
})
62+
63+
assert.deepEqual(await provider.readRecords("exports", { scope: SCOPE }), [])
64+
const audits = await provider.readRecords("audit", {
65+
scope: SCOPE,
66+
operations: ["export.create"],
67+
})
68+
assert.equal(audits.at(-1).outcome, "ok")
69+
assert.match(audits.at(-1).reason, new RegExp(preview.manifest.id))
70+
assert.match(audits.at(-1).reason, new RegExp(preview.manifest.digest))
71+
assert.equal((await store.verify(PERSON)).ok, true)
72+
})
73+
4774
it("remain valid during verification, withdrawal, and redaction", async () => {
4875
const provider = providerThatStoresHistoricalExports()
4976
const store = await createLearningStore({ provider, clock: () => NOW })

0 commit comments

Comments
 (0)