Skip to content

MSVC link errors are not properly captured #2

Description

@FiniteReality

Test case:

     3>console.obj : error LNK2019: unresolved external symbol "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl cli::detail::usage(class std::basic_ostream<char,struct std::char_traits<char> > &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >)" (?usage@detail@cli@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV34@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@4@@Z) referenced in function "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl cli::usage(class std::basic_ostream<char,struct std::char_traits<char> > &)" (?usage@cli@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV23@@Z) [D:\a\Fabulist\Fabulist\build\samples\cli\cli.vcxproj]
     3>main.obj : error LNK2019: unresolved external symbol "class std::optional<struct cli::parsed_arguments> __cdecl cli::parse_arguments(int,char const * *)" (?parse_arguments@cli@@YA?AV?$optional@Uparsed_arguments@cli@@@std@@HPEAPEBD@Z) referenced in function main [D:\a\Fabulist\Fabulist\build\samples\cli\cli.vcxproj]

Expected:

  • LNK2019 error is captured

Actual:

  • LNK2019 error is skipped

Looks like the fix is to make the line info capture optional.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions