Skip to content

default parameter to the middleware fn  #50

Description

@Amgad-Atef-Mohamed

@eiabea @marklawlor @rimiti

if (!isUndefined(actionsTmp)) {

I think this condition wrong when anyone uses the middleware without sending the permissions parameter.

const resource = numPathComponents === 0 ? url : url.split('/').slice(0, numPathComponents + 1).join('/');

also, this condition wrong when anyone uses the middleware without sending the number of Paths parameter.

Redis storage take the second parameter as a string with is the prefix but in the readme example take an object
// Using Redis store
const acl = new Aclify.Acl(new Aclify.RedisStore(RedisClient, {prefix: 'acl_'}));

so it must be:

const acl = new Aclify.Acl(new Aclify.RedisStore(RedisClient,'acl' }));

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions