Add support for multiple imageUrls for a single day's strip #141

Activity

1. ArtskydJ commented on Oct 27, 2023

   

   ArtskydJ

   on Oct 27, 2023

   Last edited by ArtskydJ

   Owner

   More actions

   Ok, so I assumed one image per day in my data model:
   https://github.com/ArtskydJ/comicsrss.com/blob/gh-pages/_generator/tmp/comicskingdom-series-objects.json

   I'd accept a PR to switch imageUrl from a string into an array of strings (and rename it imageUrls).

   To transform the existing JSON, I recommend writing a migration and running node _generator/bin --migrate.
   

   comicsrss.com/_generator/bin.js

   Lines 13 to 16 in b0b86a8

   	function migration([ id, seriesObject ]) {
   	// seriesObject.strips = seriesObject.strips.filter(s => s.date !== null && s.date.slice(7) !== '2020-09') // bye bye all this month
   	return [ id, seriesObject ]
   	}

   The migration would looks something like:

   function migration([ id, seriesObject ]) {
   	seriesObject.strips.forEach(strip => {
   		const imageUrl = strip.imageUrl
   		delete strip.imageUrl
   		strip.imageUrls = [ imageUrl ]
   	})
   	return [ id, seriesObject ]
   }

   The bigger project is changing every place that references series.strips[x].imageUrl, and making sure it's using an array instead. (Some of the linked search results refer to series.imageUrl which should stay a string.)

   If you're familiar with JavaScript, I don't think this would be very hard... But that's pretty easy for me to say since I'm familiar with my own project.

   I don't feel like I have time to make this change myself. Please reply with any more questions.

   ---

   Adding TinyView would be its own project, quite separate to the imageUrl: string -> imageUrls: string[] transformation. You'd probably want to make a new "multipage" scraper. I'd probably copy/paste from https://github.com/ArtskydJ/comicsrss.com/blob/gh-pages/_generator/scrapers/comicskingdom.js to start.
2. ArtskydJ

   changed the title [-]Add support for TinyView[/-] [+]Add support for multiple imageUrls for a single day's strip[/+] on Oct 27, 2023