kboot: disable wfi/wfit if wfi loses state - #672
Draft
yuyuyureka wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Yureka <yureka@cyberchaos.dev>
yuyuyureka
force-pushed
the
feature/wfi-bootarg
branch
from
August 29, 2026 13:07
d80fa33 to
5971b02
Compare
jannau
reviewed
Aug 29, 2026
| return dt_set_rng_seed_adt(node); | ||
|
|
||
| if (wfi_loses_state()) { | ||
| if (fdt_appendprop_string(dt, node, "bootargs", " idle=nop arm64.nowfxt")) |
Member
There was a problem hiding this comment.
does this actually work? in my test with " nohibernate" this resulted in
bootargs = "root=...", " nohibernate";
and the kernel ignored the second string. At least in its Kernel command line: debug output. I think the issue is that the existing string still has a terminating \0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.