Skip to content

Freeze escalation attrition at universe fork time - #1157

Open
KillariDev wants to merge 3 commits into
mainfrom
t3code/scan-solidity-vulnerabilities
Open

KillariDev wants to merge 3 commits into
mainfrom
t3code/scan-solidity-vulnerabilities

Conversation

@KillariDev

@KillariDev KillariDev commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

An escalation game that is unresolved when its universe forks must remain unresolved in that parent. The estimated deadline can precede the actual attrition crossing, so a fork in that rounding gap previously allowed later wall-clock time to finalize the parent, enable payouts, and reject delayed migration.

Freeze attrition at the recorded universe fork time, including continuations resumed after their universe has already forked. Preserve settlement for games finalized before the fork. Regression coverage checks delayed migration, blocked parent payouts, child carry, repeated forks, and preserved inherited elapsed time. Refresh the bytecode snapshot, derived deployment manifests, affected documentation, and deployment runtime-hash pins, including factory descendants and dependent Trading contracts. The pins are verified against fresh local deployments for mainnet, Sepolia, and deterministic-WETH testnets.

Validation:

  • Reproduced the defect before the fix; 455 selected contract, invariant, documentation, deployment-verification, scanner, and bot tests pass.
  • bun run tsc, bun run format:check, bun run check, bun run knip, bun run check:generated-clean, and git diff --check pass.
  • ABI and storage layout are unchanged. EscalationGame runtime is 24,387 bytes, within the 24,576-byte limit.
  • Chromium QA at 1440×900 and 390×844 covers the corrected documentation and both deployment-decoder networks, including invalid input and recovery. Deployment QA also covers missing/deployed contracts, pending confirmation, wallet and network blocking, and recovery at both widths. No browser errors or horizontal overflow.
  • Final review: 95/100; documentation review: 94/100; visual review: 94/100. No open findings.
  • The full root suite, app browser workflows, live-network tests, and unrelated package suites were excluded because the affected contract and deterministic-address consumers are covered by focused tests; app flows, transports, and ABI shapes did not change.

Documentation after the change:

Escalation finality explanation at desktop width

Escalation finality explanation at mobile width

Verified deployment state after refreshing runtime hashes:

Statoblast deployment at desktop width

Statoblast deployment at mobile width

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant