Repository navigation
Desktop zoom: add Cmd+0 reset and retain keypad limitation #2318
Description
Parent: #2245. Follow-up to merged #2299 / S2 #2269.
Confirmed delivery scope (2026-10-20)
The Human confirmed that recovery is the priority: deliver Cmd+0 to restore the saved device-default whole-window zoom. Keep numeric-keypad shortcuts explicitly unsupported in pinned macOS DSH0.2.1-rc.2; do not expand this slice into an alternative input router. This replaces the original request to deliver both reset and keypad defaults together.
The installed Electron main's actual parseShortcutDefinitions accepts Digit0 but rejects NumpadAdd, NumpadSubtract and Numpad0 with Unsupported shortcut code: .... Its input owner matches physical codes and forwards only registered combinations, so a Client-only normalizer change cannot cover embedded focus. No upstream or installed-app modification is allowed.
Implementation seam
Add the default primary + Digit0 binding for the existing botharness.zoom.reset command in the qualified macOS zoom lease. Reuse the native Shortcut Service/Registry, composition and recording guards, conflict policy and existing WindowZoom reset operation. Do not add a second listener/router, another store or automatic rebinding. The saved default may differ from100%.
Acceptance
- Cmd+0 invokes the existing reset command and restores the saved device default.
- Existing custom bindings/unbinding remain intact; the new default yields to an existing explicit assignment.
- Native top-document, iframe and webview focus show one reset action, retained draft/input and unchanged native font/guest zoom values; evidence identifies the tested source and package.
- Existing composition, recording, repeat, ordinary-browser and unsupported-platform owners remain authoritative.
- Numeric keypad remains clearly unsupported and is not registered or advertised as enabled.
- Focused regression, applicable checks, exact-head CI and independent Standards/Spec review pass before merge.
Reuse the existing isolated Profile and user-data. Its previous process has exited; restoring the same instance is allowed, but do not create another test Profile. No release. Windows/Linux remains separately tracked in #2270.
Delivered
Merged in #2334, commit 33da7a0c6f274e50edbc9aa9814d9a1d4eb46f07. Final-head CI and independent Standards/Spec review passed; Human confirmed Cmd+0 recovery and retained draft. Native handler-count evidence supplements the committed proof. Numeric keypad is an accepted limitation, not an uncompleted part of this issue. No release.
Activity
DoodleBears commentedon Oct 19, 2026
Agent work claim
codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264.codex/2318-zoom-default-shortcuts.[-]Desktop zoom: complete default reset and keypad shortcut qualification[/-][+]Desktop zoom: add Cmd+0 reset and retain keypad limitation[/+]DoodleBears commentedon Oct 19, 2026
Human-confirmed scope amendment (2026-10-20): deliver Cmd+0 recovery to the saved device default; numeric-keypad shortcuts remain an explicit pinned-Desktop limitation, not part of this implementation. The Human confirmed that reliable reset is sufficient and other keypad expansion is not needed now.
The native installed-main parser rejects all three Numpad codes, and the native input owner forwards only registered physical codes. Digit0 is accepted. #2318 now records this concrete boundary and the default-reset acceptance matrix. The same existing isolated Profile/user-data will be restored; no new test Profile, upstream edit or competing input router.
Task:
codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264; state: active.docs: clarify whole-window zoom recovery in release note
DoodleBears commentedon Oct 19, 2026
Agent work outcome
codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264(not a DSH Session)33da7a0c6f274e50edbc9aa9814d9a1d4eb46f07; closes Desktop zoom: add Cmd+0 reset and retain keypad limitation #2318 only.8b46c1771185ae30695fa6526b20e5deb0c52397passed applicable CI; Standards/Spec passed. Human QA confirmed normal-size recovery and retained draft. Direct handler instrumentation proved one invocation per main/iframe/webview sample; fonts/input/guest zoom were retained. Runtime source is unchanged from the native-testedfe95f1d16(the final delta only clarifies Chinese release wording).fix(client): restore default window zoom with Cmd+0 (BotHarness#2334)