Repository navigation
Me/dpc 5790 update attribution to r4 - #3175
Merged
Merged
Conversation
ashley-weaver
approved these changes
Oct 22, 2026
ashley-weaver
left a comment
ashley-weaver
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Changes in data models between versions are handled properly.
lukey-luke
reviewed
Oct 22, 2026
| run: | | ||
| find . -name dpc-api-jacoco.xml | ||
| # SonarQube flags us for duplicate code in the stu3 and r4 versions of classes. This is by design. Once we remove | ||
| # v1 and stu3 delete the "sonar.cpd.exclusions" parameter |
lukey-luke
approved these changes
Oct 22, 2026
lukey-luke
left a comment
lukey-luke
left a comment
Contributor
There was a problem hiding this comment.
Resource tests are passing (test/java/gov/cms/dpc/api/resources/v1/{}.java) ✅
K6 smoketests are passing ✅
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5790
🛠 Changes
Prepares dpc-attribution for new R4 endpoints, including:
There will be other PRs as part of this ticket to build the R4 based endpoints.
Note:
From the user's perspective, there are no functionality changes and this should be safe to deploy. This is basically a plumbing update.
ℹ️ Context
We're getting ready to support BFDv3 and dpc-attribution needs to be able to handle R4 resources. Unfortunately, many of our classes were coupled tightly to STU3, so a lot of this PR is making new R4 versions with the occasional tweak where something changed between versions.
There are places where we could've updated our existing classes to handle both STU3 and R4, but it usually made the code a lot uglier, and since the STU3 code will be going away when BFDv1 is deprecated in a few months, I didn't think it was worth the effort to make it work. Also, keeping everything separate means we can just
Ctrl-F "STU3"and delete everything we find when it's time to get rid of v1.The DB changes are necessary because a handful of values like
address_useandname_usecome from enumerated types in HAPI FHIR.address_usespecifically changed between versions. In STU3,address_use=4is NULL, in R4address_use=4is BILLING. That means rows created in STU3 may not convert to R4 correctly and vice versa.To deal with this, we'll store these values as string representations from now on. More values may be added from version to version, but existing string values should never change (i.e., HOME will always be HOME and BILLING will always be BILLING) and we won't have to deal with this again.
🧪 Validation
All tests passing.
Deployed to dev here.