BLS secret key validation is missing #96

Activity

1. dapplion commented on Jun 3, 2021

   

   dapplion

   on Jun 3, 2021

   Contributor

   More actions

   Thanks for looking into this! I think BLST takes care of that, but it would be good to add a test. Transfering to bls repo.
2. dapplion

   transferred this issue fromChainSafe/lodestaron Jun 3, 2021
3. dapplion

   added

   good first issue

   help wanted

   on Jun 3, 2021
4. dnkolegov commented on Jun 3, 2021

   

   dnkolegov

   on Jun 3, 2021

   Author

   More actions

   The following test for SK = q+1 will pass and will not raise an exception.

   describe("q+1 secret key", () => {
       const qHex = fromHex("73eda753299d7d483339d80809a1d80553bda402fffe5bfeffffffff00000002");
       const sk = bls.SecretKey.fromBytes(qHex);
       const msg = Buffer.from("sample-msg");
       const sig = sk.sign(msg);
       const pk = sk.toPublicKey();
       console.log(pk.toBytes())
       it("verify", () => {
         const valid = bls.verify(msg, pk, sig);
         expect(valid).to.equal(true);
       });
       
    });
   
5. dapplion commented on Jun 3, 2021

   

   dapplion

   on Jun 3, 2021

   Contributor

   More actions

   Feel free to do a PR with the test and a fix if you want! I can do the latter if you need help.
6. philknows

   added

   meta-good-first-issue

   meta-help-wanted

   and removed

   good first issue

   help wanted

   on Jul 13, 2022
7. philknows

   added

   help wanted

   good first issue

   and removed

   meta-good-first-issue

   meta-help-wanted

   on Oct 10, 2024