London | 26 - ITP-Sep | Ebrahim Moqbel | Sprint 3 | Implement and ewrite tests - #1609
Open
Ebrahim-Moqbel wants to merge 10 commits into
Open
Conversation
…nstead of invalid angle.
This comment has been minimized.
This comment has been minimized.
Ebrahim-Moqbel
added
📅 Sprint 3
Khantdotcom
added
Review in progress
Khantdotcom
suggested changes
Sep 5, 2026
Khantdotcom
left a comment
Khantdotcom
left a comment
There was a problem hiding this comment.
Mandatory fix : Typo in 3-get-card-value.js
| return +rank; | ||
| } | ||
| if (!["K", "10", "Q", "J"].includes(rank)){ | ||
| throw new error (`Invalid card rank: ${rank}`) |
There was a problem hiding this comment.
You have a typo in this line, which will raise ReferenceError. Check out this article for Javascript Errors.
Khantdotcom
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1059
Changelist
completed the implement and rewrite tests directory
Questions
N/A