Repository navigation
ROX-37502: Move core scan tests (batch 4/4) to scan-config suite - #1473
Conversation
|
@redhat-chai-bot: This pull request references ROX-37502 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @redhat-chai-bot. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
🤖 To deploy this PR, run the following command: |
80ca88c to
d40043c
Compare
redhat-chai-bot
changed the title
|
🤖 To deploy this PR, run the following command: |
d40043c to
d7520d1
Compare
d7520d1 to
62690b9
Compare
|
🤖 To deploy this PR, run the following command: |
|
🤖 To deploy this PR, run the following command: |
62690b9 to
4c5340f
Compare
|
🤖 To deploy this PR, run the following command: |
4c5340f to
f3795ae
Compare
|
🤖 To deploy this PR, run the following command: |
f3795ae to
f05f82c
Compare
|
🤖 To deploy this PR, run the following command: |
|
/retest |
2fa1fa5 to
abdabe7
Compare
|
🤖 To deploy this PR, run the following command: |
Move TestScanWithInvalidProfileFails, TestMissingPodInRunningState, and TestSuiteWithContentThatDoesNotMatch from parallel to scan-config suite. Remove unused imports (math/rand, controller-runtime/client) from parallel/main_test.go and add math/rand to scan-config.
abdabe7 to
633262d
Compare
|
🤖 To deploy this PR, run the following command: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redhat-chai-bot, rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Moves 3 core scan lifecycle tests from the monolithic
tests/e2e/parallel/main_test.gointo the existingtests/e2e/scan-config/main_test.gosuite.Tests moved
TestSuiteWithContentThatDoesNotMatchTestScanCleansUpComplianceCheckResultsTestScanWithoutBundlePassesDeprecationCheckContext
Part of ROX-37502 (dissolving the monolithic parallel suite into functional suites). Originally planned for a new
core-scansuite, but the team decided to merge these intoscan-configinstead — therun_if_changedtriggers would be nearly identical, so a separate suite would provision an extra cluster for minimal CI efficiency gain.Pure move only — no refactoring.
AI-generated. Review for accuracy.
@rhmdnd requested from Slack