Author browse links on item page open in a new tab, unlike other browse links

[MMilosz]

Describe the bug

On the item page, clicking an author opens /browse/author in a new tab, while other browse links, like issue date, open in the same tab

• Spotted on sandbox.dspace.org
• Confirmed this does not occur on demo.dspace.org (DSpace 10), however, this should be confirmed in the code (see next bullet)
• demo.dspace.org renders authors with ds-plain-text-metadata-list-element while sandbox.dspace.org uses ds-browse-link-metadata-list-element

Bug is browser-independent (reproduced on Chrome v154.0 and Firefox v156)

To Reproduce

Compare:

• (not ok) https://sandbox.dspace.org/entities/publication/2574d334-41d8-481e-be5a-cf2980ee17f0
• (ok) https://demo.dspace.org/entities/publication/2574d334-41d8-481e-be5a-cf2980ee17f0

Or:

1. On sandbox.dspace.org, go to /browse/author, select any author and open any publication that does not have relationships to Person entities (so authors are displayed as a list)
2. Observe: click an author and it opens in a new tab. Click the date and it stays in the same tab
3. Compare with DSpace 10 (demo.dspace.org)

Expected behavior

Author links should open in the same tab, consistent with other browse links

Related work

No directly related issues found

Additional Consideration

It may be worth auditing other *-metadata-list-element components for consistent link behavior

[MMilosz]

Hmm... After writing this, I noticed that the plain-text has duplicated @metadataRepresentationComponent for Publication with both PlainText and AuthorityControlled defined, maybe that's the reason?

dspace-angular/src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.ts

Lines 23 to 25 in 2ade1e4

	@metadataRepresentationComponent('Publication', MetadataRepresentationType.PlainText)
	@metadataRepresentationComponent('Publication', MetadataRepresentationType.AuthorityControlled)
	export class PlainTextMetadataListElementComponent extends MetadataRepresentationListElementComponent {

dspace-angular/src/app/shared/object-list/metadata-representation-list-element/authority-link/authority-link-metadata-list-element.component.ts

Lines 23 to 27 in 2ade1e4

	@metadataRepresentationComponent('Publication', MetadataRepresentationType.AuthorityControlled)
	@metadataRepresentationComponent('Person', MetadataRepresentationType.AuthorityControlled)
	@metadataRepresentationComponent('OrgUnit', MetadataRepresentationType.AuthorityControlled)
	@metadataRepresentationComponent('Project', MetadataRepresentationType.AuthorityControlled)
	export class AuthorityLinkMetadataListElementComponent extends MetadataRepresentationListElementComponent implements OnInit {

(I won't be working on this issue, but I'm happy to test any PR that fixes it)