Simplify default SSR excludePathPatterns (and consider prefix matching instead of regex) - #6279
Open
saschaszott wants to merge 8 commits into
Open
saschaszott wants to merge 8 commits into
saschaszott wants to merge 8 commits into
Conversation
Refactored excludePathPatterns to simplify regex patterns.
Contributor
Author
|
Please note that this PR is currently causing some SSR checks in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
n/a
Description
This PR simplifies the default
ssr.excludePathPatternsto plain path prefixes.Since none of the remaining defaults actually needs regex features anymore, this PR also asks the community whether regex matching is still needed, or whether a simple prefix check (
path.startsWith(prefix)) would be sufficient.The current defaults mix anchored (
$) and unanchored patterns, which is easy to get wrong:^/statistics/?/^/processes/?: the optional/?has no effect without$^/community-list$/^/health$: a trailing slash is not matched (/community-list/is still rendered via SSR)Question to reviewers / the DSpace community
Do we still need regex support for
excludePathPatterns, or would a simple URL path "startsWith" check be enough?Arguments for a prefix check (and against regex-based comparision):
Instructions for Reviewers
/search,/browse) and check that the server log printsUniversal off, serving for direct client-side rendering (CSR)/,/items/<uuid>) and check that the page is server-side rendered (view source contains rendered content)Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.