Repository navigation
chore(check): Flutter steps use the CI-pinned SDK when it is installed - #378
Merged
Merged
Conversation
A system Flutter upgrade (3.50, whose analyzer flags package:flutter/material.dart as deprecated) failed every push's flutter-a2ui/flutter-explorer steps while CI (3.44.4) was green. The Flutter steps now put $TRITON_FLUTTER_HOME, else ~/.local/share/flutter-$FLUTTER_PIN, first on PATH, and fall back to the system flutter with the existing version note. The 3.50 move itself is blocked (google_fonts still builds on the SDK's Material; no newer cirruslabs build image); noted in realizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The machine's system Flutter moved to 3.50. Its analyzer flags
package:flutter/material.dartas deprecated (Material moved to the pub packagematerial_ui), so the pre-pushflutter-a2uiandflutter-explorersteps failed on every push, while CI, pinned to 3.44.4, was green.What
scripts/check.shgetsuse_pinned_flutter. The Flutter steps put$TRITON_FLUTTER_HOME, else~/.local/share/flutter-$FLUTTER_PIN, first on PATH. Without either, they fall back to the systemflutterand print the existing version note. The script has a one-line install command for the pinned SDK. CI is unchanged.Why not move to 3.50 / material_ui now
google_fonts, and even its latest release (8.2.1) still builds on the SDK's Material.material_ui's classes are distinct types, soGoogleFonts.interTextTheme()no longer fitsThemeData.textTheme.a2ui_fluttermigrates cleanly.ghcr.io/cirruslabs/flutter, publishes nothing newer than 3.44.0; itsstabletag is 3.44.0, built 2026-05-20.Recorded in
doc/realizations.md§7, to revisit when the ecosystem moves.Evidence
scripts/check.sh flutter-a2uipasses. It failed before this change.TRITON_FLUTTER_HOME=/nonexistent: the version note appears and the 3.50 analyzer findings fail the step, as before.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.