Skip to content

chore(check): Flutter steps use the CI-pinned SDK when it is installed - #378

Merged
jrosskopf merged 1 commit into
mainfrom
chore/check-pinned-flutter
Nov 18, 2026
Merged

jrosskopf merged 1 commit into
mainfrom
chore/check-pinned-flutter

Conversation

@jrosskopf

@jrosskopf jrosskopf commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Why

The machine's system Flutter moved to 3.50. Its analyzer flags package:flutter/material.dart as deprecated (Material moved to the pub package material_ui), so the pre-push flutter-a2ui and flutter-explorer steps failed on every push, while CI, pinned to 3.44.4, was green.

What

scripts/check.sh gets use_pinned_flutter. The Flutter steps put $TRITON_FLUTTER_HOME, else ~/.local/share/flutter-$FLUTTER_PIN, first on PATH. Without either, they fall back to the system flutter and print the existing version note. The script has a one-line install command for the pinned SDK. CI is unchanged.

Why not move to 3.50 / material_ui now

  • google_fonts: the explorer uses google_fonts, and even its latest release (8.2.1) still builds on the SDK's Material. material_ui's classes are distinct types, so GoogleFonts.interTextTheme() no longer fits ThemeData.textTheme. a2ui_flutter migrates cleanly.
  • Build image: the explorer image's build base, ghcr.io/cirruslabs/flutter, publishes nothing newer than 3.44.0; its stable tag is 3.44.0, built 2026-05-20.

Recorded in doc/realizations.md §7, to revisit when the ecosystem moves.

Evidence

  • System Flutter 3.50 on PATH, pinned 3.44.4 installed: scripts/check.sh flutter-a2ui passes. It failed before this change.
  • TRITON_FLUTTER_HOME=/nonexistent: the version note appears and the 3.50 analyzer findings fail the step, as before.
  • Pre-push gate: 9/9 steps with no PATH prefix.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

A system Flutter upgrade (3.50, whose analyzer flags
package:flutter/material.dart as deprecated) failed every push's
flutter-a2ui/flutter-explorer steps while CI (3.44.4) was green. The
Flutter steps now put $TRITON_FLUTTER_HOME, else
~/.local/share/flutter-$FLUTTER_PIN, first on PATH, and fall back to the
system flutter with the existing version note. The 3.50 move itself is
blocked (google_fonts still builds on the SDK's Material; no newer
cirruslabs build image); noted in realizations.
@jrosskopf
jrosskopf merged commit 3fd015f into main Nov 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant