Repository navigation
feat(core): implement BinaryFileReader for safe and efficient binary I/O - #2
Merged
Merged
Conversation
Dev-Sams1012
force-pushed
the
feat/core/BinaryFileReader
branch
from
July 27, 2026 01:29
c047a2e to
6f2af82
Compare
- Add `BinaryFileReader` class to manage binary files using RAII (`std::ifstream`). - Enforce `std::ios::binary` flag to prevent silent data corruption during ROM parsing. - Implement `read_at()` for targeted offset reading. - Implement `read_next_chunk()` for block-based reading to process large files without exhausting RAM. - Utilize `std::filesystem::file_size` for total size tracking. - Throw `std::runtime_error` on file open failure to guarantee fail-safe operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryFileReaderclass to manage binary files using RAII (std::ifstream).std::ios::binaryflag to prevent silent data corruption during ROM parsing.read_at()for targeted offset reading.read_next_chunk()for block-based reading to process large files without exhausting RAM.std::filesystem::file_sizefor total size tracking.std::runtime_erroron file open failure to guarantee fail-safe operations.