Skip to content

Fix tests and ci - #44

Open
M-Chan wants to merge 42 commits into
new-mainfrom
ci_tests
Open

M-Chan wants to merge 42 commits into
new-mainfrom
ci_tests

Conversation

@M-Chan

@M-Chan M-Chan commented Oct 30, 2026

Copy link
Copy Markdown

No description provided.

these are commented out on working branch
mock_queue.called was for a python function?
mock_process was never used
updte_func() no longer returns a value and disable_polling_status() is a pyqtSlot
@M-Chan
M-Chan requested a review from JamesOHeaDLS October 30, 2026 16:54
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (6891d24) to head (1d37bb3).
⚠️ Report is 2 commits behind head on new-main.

Files with missing lines Patch % Lines
src/dls_pmac_control/comms_thread.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           new-main      #44      +/-   ##
============================================
+ Coverage     88.52%   90.15%   +1.62%     
============================================
  Files            24       25       +1     
  Lines          4986     4967      -19     
============================================
+ Hits           4414     4478      +64     
+ Misses          572      489      -83     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant