TSM-92: enable noImplicitAny and harden typing - #576
Merged
Justin Hammond (Justintime50) merged 523 commits intoSep 1, 2026
Merged
Conversation
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/92-no-implicit-any-hardening
branch
from
August 24, 2026 19:20
e44ffa2 to
66dc49d
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/92-no-implicit-any-hardening
branch
2 times, most recently
from
August 24, 2026 19:28
d47bde3 to
9a62d5e
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/92-no-implicit-any-hardening
branch
from
August 24, 2026 19:32
9a62d5e to
43b6b9e
Compare
Alex Matthews (ralexmatthews)
left a comment
Alex Matthews (ralexmatthews)
left a comment
Contributor
There was a problem hiding this comment.
Hmmm... so this turns off noImplicitAny, but then it types a bunch of them as any anyway so we are not getting a lot of a wins of TS.
In some of these place where stuff could be anything, like in the response checkers or errors, I think we should prefer unknown. any uses honor-system checking, "Yes TS, I promise I checked that this should work". unknown has TS check that it will work as expected. Its more verbose in places but a lot more type safe.
You could also make the errors default to unknown with the tsconfig setting.
Alex Matthews (ralexmatthews)
approved these changes
Sep 1, 2026
Alex Matthews (ralexmatthews)
left a comment
Alex Matthews (ralexmatthews)
left a comment
Contributor
There was a problem hiding this comment.
Niiiiice alot better 👏
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/92-no-implicit-any-hardening
branch
from
September 1, 2026 19:33
23a8368 to
8a9771e
Compare
Justin Hammond (Justintime50)
changed the base branch from
ts-migrate/91-cleanup-calibration
to
master
September 1, 2026 19:40
Justin Hammond (Justintime50)
changed the base branch from
master
to
ts-migrate/91-cleanup-calibration
September 1, 2026 19:40
Steven Roomberg (sroomberg-ep)
approved these changes
Sep 1, 2026
Justin Hammond (Justintime50)
deleted the
ts-migrate/92-no-implicit-any-hardening
branch
September 1, 2026 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation