Show the QR scanner scam warning after the camera permission is granted

[peachbits]

Description

Asana: QR Scanner - Modal disappears after permission grant

ScanModal chose its entire body from one ternary keyed on state.permissions.camera, and requested that permission from its own mount effect. The scam warning lived only in the not-granted branch, alongside the "enable Camera access in Settings" recovery text.

Redux seeds camera: 'denied', so on a fresh install the modal opened straight into the Settings guidance before the user had ever been asked, the OS prompt landed on top of that, and answering it flipped the ternary. The warning's subtree was then unmounted by React rather than through bridge.resolve, so it disappeared without its exit animation — the reported flash. The only way to read the warning at all was to deny the camera.

showScanModal now runs the three steps in sequence, so none of them can overlap:

1. Request the OS camera permission, with no Edge modal on screen behind it.
2. If denied or blocked, show the Settings recovery guidance and stop.
3. On the first camera use only, wait for an explicit acknowledgement of the scam warning.
4. Only then mount the scanner.

Waiting for the app to return to the foreground keeps the warning from being presented while it is still coming back from the OS prompt. ScanModal is left as just the camera sheet, with no permission branch to swap.

Notes for review:

• The scam warning is a non-skippable ConfirmContinueModal, so backdrop tap, swipe-down, hardware back and the close button are all disabled — it takes the checkbox and confirm button to dismiss. That also means it passes no onCancel, so EdgeModal ignores Airship's global clear event; the modal handles clear itself rather than outliving a logout and leaving the caller awaiting a promise that never settles.
• The acknowledgement is persisted per account as cameraScamWarningShown, written after the modal resolves, so a force-quit mid-warning shows it again.
• ScanModal deliberately does not re-check the permission on foreground to swap back to the recovery UI. That branch swap is the flash bug in reverse.
• WcConnectionsScene picks up return-type and catch-variable fixes that its removal from the ESLint warnings list now requires.

Verification: tsc, eslint and the full jest suite pass.

Walked through on the iOS simulator and on Android (Pixel 9 Pro, API 36): the OS prompt appears with no Edge modal behind it; on Allow the scam warning appears and stays until the checkbox and Confirm & Finish are tapped; the scanner then opens. With camera access revoked, only the Settings guidance shows -- no scam card. The first-use gate was confirmed by reading cameraScamWarningShown: true back out of the device-local Settings.json after acknowledgement.

The Android pass is the case Jon raised on the ticket -- "Android, if tapping allow, does not allow the modal to persist for the user" -- and the warning does persist here.

Entry points exercised: Side Menu -> Scan QR on both platforms, Send -> Scan on iOS. WalletConnect -> New Connection was not clicked through, though all three now route through the same showScanModal thunk, and an eslint rule prevents any call site from mounting ScanModal directly and skipping the sequencing.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

Note

Medium Risk
Changes the shared QR scan flow (permission, first-use safety modal, and persistence) across several entry points; regressions would affect camera access or whether users see the scam warning.

Overview
Fixes the QR scam warning flashing away when users tap Allow on the OS camera prompt. ScanModal no longer requests permission or switches UI based on Redux camera state; it is only the camera sheet once access is granted.

showScanModal in ScanActions is now the required entry point: request camera permission with no Edge modal behind the OS dialog, waitForForeground after the prompt, then either CameraPermissionDeniedModal (Settings guidance only) or, on first use per account, a non-skippable ScanScamWarningModal whose acknowledgement is stored as cameraScamWarningShown, and finally the scanner. Side menu, send address scan, and WalletConnect new connection dispatch showScanModal instead of mounting ScanModal directly; eslint blocks direct ScanModal imports except from ScanActions.

^{Reviewed by Cursor Bugbot for commit 74dfc47. Bugbot is set up for automated code reviews on this repo. Configure here.}

[claude]

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

_{Tip: disable this comment in your organization's Code Review settings.}