Conversation
j0ntz
marked this pull request as ready for review
September 4, 2026 09:10
j0ntz
force-pushed
the
jon/wc-clarify-risks
branch
from
September 4, 2026 09:10
c324c9a to
3ddf212
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
j0ntz
force-pushed
the
jon/wc-clarify-risks
branch
2 times, most recently
from
September 9, 2026 05:53
6f6019e to
23c6ba5
Compare
j0ntz
force-pushed
the
jon/wc-clarify-risks
branch
from
September 16, 2026 09:32
23c6ba5 to
f641bfe
Compare
Contributor
Author
Test evidence: allowances revert (f641bfe)Confirm Connection allowances are back to develop's plain secondary-colored text; the Connect button stays pinned. Driven on the iOS sim from a host WalletConnect dApp through Connect to Active Connections.
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Edge showed near-identical safety language at two different WalletConnect moments: the initial connection, which shares the selected public address and opens a session but moves no funds, and a later transaction or signature request, which may move assets or authorize future transfers. This separates the two.
Confirm Connection screen now reads:
Smart Contract Call screen now reads:
The Smart Contract Call warning renders in
AlertCardUi4, the solid UI4 warning card, instead of the outline-onlyAlert. Both branches of that warning (the copy above and the insufficient-fee message) use the same card, so the modal has one warning footprint.wc_smartcontract_warning_textis replaced bywc_smartcontract_warning_point_fundsandwc_smartcontract_warning_point_trust, which render as the card's two bullet points.The Confirm Connection layout follows a later comment on the same task. The allowances were one secondary-colored block split on
\n; they now render as bullet points in the default primary text through a newBulletListcomponent (src/components/text/BulletList.tsx), andwc_confirm_bodyis split intowc_confirm_body_point_addressandwc_confirm_body_point_transactionsso translators see the list structure. The Connect button moves out of theScrollViewand becomes<SceneButtons absolute />, the same configurationWalletRestoreSceneuses, with the scroll content padded bySCENE_BUTTONS_MARGIN_REMso nothing sits under the floating button. No new hand-rolled positioning views.Copy approved by Jon Tzeng on the Asana task; the UI4 card was requested in the same comment.
Asana: https://app.asana.com/0/1215088146871429/1217260776555871
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
User-facing copy and WalletConnect confirmation layout only; no auth, signing, or session-approval logic changes beyond the address API call swap.
Overview
Separates WalletConnect safety messaging so connection approval and smart-contract/transaction approval no longer read like the same risk. Confirm Connection copy now leads with viewing the wallet address, then requesting transaction approval. The Smart Contract Call modal replaces the old single warning paragraph with two bullet points about funds/permissions and trusting the app.
The smart-contract warning (including the insufficient-fee branch) now uses the solid
AlertCardUi4card instead of the outlineAlert, with copy split intowc_smartcontract_warning_point_fundsandwc_smartcontract_warning_point_trust.On Confirm Connection, Connect moves out of the scroll area to
SceneButtonswithabsolutepinning (matching other scenes), with scroll padding so content clears the floating button. Wallet address loading switches fromgetReceiveAddresstogetAddresses.CHANGELOG and ESLint file lists are updated;
WcConnectScene/WcSmartContractModalpick up minor typing and lint cleanup.Reviewed by Cursor Bugbot for commit f641bfe. Bugbot is set up for automated code reviews on this repo. Configure here.
Test evidence
b986473Fix lint warnings in WcConnectScene
confirm connection
connected
f641bfeClarify WalletConnect connection and request risks
confirm connection
connected
smart contract warning
seg4 confirm connection plain allowances
seg4 active connections