Skip to content

Clarify WalletConnect connection and request risks - #6196

Open
j0ntz wants to merge 3 commits into
developfrom
jon/wc-clarify-risks
Open

j0ntz wants to merge 3 commits into
developfrom
jon/wc-clarify-risks

Conversation

@j0ntz

@j0ntz j0ntz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Edge showed near-identical safety language at two different WalletConnect moments: the initial connection, which shares the selected public address and opens a session but moves no funds, and a later transaction or signature request, which may move assets or authorize future transfers. This separates the two.

Confirm Connection screen now reads:

Allow <dApp> to:

  • View your wallet address
  • Request approval for transactions

Smart Contract Call screen now reads:

Warning

  • Approving this request may move funds or grant permissions
  • Only continue if you trust this application and expected this request

The Smart Contract Call warning renders in AlertCardUi4, the solid UI4 warning card, instead of the outline-only Alert. Both branches of that warning (the copy above and the insufficient-fee message) use the same card, so the modal has one warning footprint.

wc_smartcontract_warning_text is replaced by wc_smartcontract_warning_point_funds and wc_smartcontract_warning_point_trust, which render as the card's two bullet points.

The Confirm Connection layout follows a later comment on the same task. The allowances were one secondary-colored block split on \n; they now render as bullet points in the default primary text through a new BulletList component (src/components/text/BulletList.tsx), and wc_confirm_body is split into wc_confirm_body_point_address and wc_confirm_body_point_transactions so translators see the list structure. The Connect button moves out of the ScrollView and becomes <SceneButtons absolute />, the same configuration WalletRestoreScene uses, with the scroll content padded by SCENE_BUTTONS_MARGIN_REM so nothing sits under the floating button. No new hand-rolled positioning views.

Copy approved by Jon Tzeng on the Asana task; the UI4 card was requested in the same comment.

Asana: https://app.asana.com/0/1215088146871429/1217260776555871

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
User-facing copy and WalletConnect confirmation layout only; no auth, signing, or session-approval logic changes beyond the address API call swap.

Overview
Separates WalletConnect safety messaging so connection approval and smart-contract/transaction approval no longer read like the same risk. Confirm Connection copy now leads with viewing the wallet address, then requesting transaction approval. The Smart Contract Call modal replaces the old single warning paragraph with two bullet points about funds/permissions and trusting the app.

The smart-contract warning (including the insufficient-fee branch) now uses the solid AlertCardUi4 card instead of the outline Alert, with copy split into wc_smartcontract_warning_point_funds and wc_smartcontract_warning_point_trust.

On Confirm Connection, Connect moves out of the scroll area to SceneButtons with absolute pinning (matching other scenes), with scroll padding so content clears the floating button. Wallet address loading switches from getReceiveAddress to getAddresses.

CHANGELOG and ESLint file lists are updated; WcConnectScene / WcSmartContractModal pick up minor typing and lint cleanup.

Reviewed by Cursor Bugbot for commit f641bfe. Bugbot is set up for automated code reviews on this repo. Configure here.

Test evidence

b986473
Fix lint warnings in WcConnectScene

confirm connection

connected
f641bfe
Clarify WalletConnect connection and request risks

confirm connection

connected

smart contract warning

seg4 confirm connection plain allowances

seg4 active connections

@j0ntz
j0ntz marked this pull request as ready for review September 4, 2026 09:10
@j0ntz
j0ntz force-pushed the jon/wc-clarify-risks branch from c324c9a to 3ddf212 Compare September 4, 2026 09:10
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz
j0ntz force-pushed the jon/wc-clarify-risks branch 2 times, most recently from 6f6019e to 23c6ba5 Compare September 9, 2026 05:53
@j0ntz
j0ntz force-pushed the jon/wc-clarify-risks branch from 23c6ba5 to f641bfe Compare September 16, 2026 09:32
@j0ntz

j0ntz commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Test evidence: allowances revert (f641bfe)

Confirm Connection allowances are back to develop's plain secondary-colored text; the Connect button stays pinned. Driven on the iOS sim from a host WalletConnect dApp through Connect to Active Connections.


Confirm Connection, plain allowances

Active Connections after Connect

The confirm connection and connected frames stamped 20260904 and 20260908 in the description table predate this commit. The description paragraph that mentions BulletList and the split locale keys is also out of date: both were removed in this push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant