Show both the seed phrase and private key - #6207
Open
j0ntz wants to merge 2 commits into
Open
Conversation
These files leave the warning suppression list once they are touched.
Contributor
Author
j0ntz
marked this pull request as ready for review
September 9, 2026 01:05
j0ntz
force-pushed
the
jon/seed-vs-private-key
branch
from
September 9, 2026 01:05
d6e5575 to
424f8c6
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 424f8c6. Configure here.
`getDisplayPrivateKey` now returns the wallet's seed phrase whenever it has one, so Master Private Key would otherwise stop offering the hex key that MetaMask-style imports ask for. Show both, labeled, whenever the wallet stores a hex key that differs from what the plugin chose to display. A wallet imported from a raw private key has no seed and still shows a single value. The uniswapV2 stake policies used the same call as an ethers signing key, which only accepts a private key. They now read the stored hex key directly.
j0ntz
force-pushed
the
jon/seed-vs-private-key
branch
from
September 9, 2026 01:23
424f8c6 to
e266853
Compare
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-currency-accountbased#1097
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana: https://app.asana.com/0/1215088146871429/1210071879529859
The dependency PR makes
getDisplayPrivateKeyreturn the wallet's seed phrasewhenever it has one, so Wallet Options > Master Private Key would otherwise
stop offering the hex key that MetaMask-style imports ask for. This shows both,
labeled, whenever the wallet stores a hex key that differs from what the plugin
chose to display:
A wallet imported from a raw private key has no seed and still shows a single
value, exactly as before.
The hex key comes from
account.getRawPrivateKey()via a newgetWalletHexPrivateKeyhelper, keyed on the${pluginId}Keyname theaccount-based EVM plugins use, and gated on the value matching
/^(0x)?[0-9a-fA-F]{64}$/. That field name is a cross-family convention ratherthan an EVM one, and the UTXO plugins keep a base64 or WIF seed under it, so the
shape check is what keeps a Bitcoin-family seed from surfacing as a bogus
Master Private Key. Anything that fails it gets the single-value modal, sothere is no per-chain allowlist to keep current.
Stake-policy regression this also fixes
The uniswapV2 stake policies (Tomb masonry and cemetery on Fantom, Velodrome V2
on Optimism) passed
account.getDisplayPrivateKey()straight intonew ethers.Wallet(seed), which only accepts a private key. Once the pluginreturns a mnemonic those six call sites break, so they now read the stored hex
key through
getSignerSeed.The first commit clears pre-existing lint warnings in the two files that leave
the suppression list once touched.