Repository navigation
fix: slice saved datasets by split, overwrite EK-FAC fit - #564
Merged
Merged
Conversation
load_data_string now applies split expressions such as train[:100] and train[:10%]+test to datasets loaded with load_from_disk, where it took the whole dataset or raised. The EK-FAC pipeline promotes its apply and ASTRA outputs with promote_step, so a rerun replaces a finished output in place of moving its .part directory inside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
luciaquirke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_data_stringloads directories saved withsave_to_diskthroughload_from_disk.Dataset, it droppedsplit:--split "train[:8]"loaded every row.DatasetDict, it raised on any slice or+.promote_step.