Repository navigation
feat(api): vault sessions require member-key proof - #145
Closed
BRAVO68WEB wants to merge 2 commits into
Closed
BRAVO68WEB wants to merge 2 commits into
BRAVO68WEB wants to merge 2 commits into
Conversation
getVaultSessionToken unwraps the system member key, signs a server nonce, and calls CreateSessionByCert. Serial-only CreateSessionManaged is no longer used. Missing durable member keys fail closed with MEMBER_KEY_UNAVAILABLE.
Enable control-plane TLS with a dedicated gRPC CA. Compose and Swarm mount server and API client certs; the API presents the client cert. Vault sessions already use cert proof; serial-only mint is gone on the miniKMS side.
This was referenced Sep 26, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vault sessions require a member-key signature (this PR). miniKMS counterpart: minikms#11 now removes `CreateSessionManaged` and requires an API client cert when TLS is on.
Program / phase
No-piggyback checklist
Tests
miniKMS session/vault unit tests pass. Deploy render tests pass.
Risk / rollout
Must ship a miniKMS image built from minikms#11 with this API. Old images still accept managed sessions and no mTLS; new miniKMS with TLS+client CA will reject an API that does not present the client cert.
Local: set the `MINIKMS_TLS_*_FILE` paths in `.env` (see `.env.example`) and recreate the miniKMS container.