Repository navigation
fix(deploy): generate missing miniKMS gRPC certs (0.23.2) - #149
Merged
Merged
Conversation
x509 -req -addext fails on OpenSSL 1.1.1 and LibreSSL
("Multiple digest or unknown options: -sha256 and -addext").
Sign with a temp extfile instead, and force MINIKMS_TLS_* from
the generated template so upgrades do not keep TLS disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Upgrading to 0.23.1 fails on hosts whose
openssl x509does not accept-addext(OpenSSL 1.1.1 / LibreSSL):Local
deploy.envalso keptMINIKMS_TLS_ENABLED=falsefrom the previous template, which would leave the API talking plaintext to a TLS-required sidecar.What
-extfile(portable across OpenSSL 1.1.1, 3.x, and LibreSSL)MINIKMS_TLS_*from the generated template on init/upgrade so existing installs pick up mTLSAfter merge
Push tag
v0.23.2on the newmainHEAD.