Repository navigation
Conversation
refactor FilterBar > SavedFilter
- loading indicator when fetching dimensions - add saved filters button width
- add hook for saved filter logic in FilterSelector - add unsaved changes warning
- refactor to use own buildFilter method instead of sGetNamedItemFilters
… Combine with not owner message.
- apply visibility updates on actions based on permissions
|
@eperedo It seems I am not able to generate a build from this branch, Claude is referring to some issue with duplicate AppWrapper files. Could you please check if you are able to build a .zip from this branch? |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
Important notes
Check metadata pre-requisites here #2
📝 Implementation
v101.4.2d2was removed so dataStore/userDataStore implementation was refactor to use thedataEnginequery/mutation style.useCachedDataQueryhook was removed. Now in order to get currentUser and rootOrgUnits there're two different hooks:useCurrentUseranduseRootOrgUnitsjstojsx🔥 Notes to the reviewer
📹 Screenshots/Screen capture
Dashboard-DHIS2_saved_filters_42.mp4