BMP File Loader - #7
Open
SzymonSliwinski wants to merge 3 commits into
Open
SzymonSliwinski wants to merge 3 commits into
SzymonSliwinski wants to merge 3 commits into
Conversation
h4570
requested changes
Jul 13, 2021
h4570
left a comment
h4570
left a comment
Member
There was a problem hiding this comment.
Please fix following issues, and and create some tests! :)
You can create first test in FileLoaderTests/ImageLoaders/BMPLoaderTests.cs which will be using dummy and small! bmp file from FileLoaderTests/Resources/dummy.bmp. After it you can create two tests on var res = Load(...) that will check res.Width and res.Height of this file :)
| } | ||
| catch | ||
| { | ||
| throw new NotImplementedException(); |
Member
There was a problem hiding this comment.
Please create your own Exception, place it in FileLoader/Exceptions and throw it there instead of NotImplementedException. For example BMPFileLoadingException.
Dont forget to comment it https://docs.microsoft.com/pl-pl/dotnet/csharp/programming-guide/xmldoc/exception
h4570
reviewed
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting few BMP properties from it's bytes