Repository navigation
Conversation
Contributor
|
Droid finished @l30t's task —— View job Droid review summary Solid wiring change overall, with tests covering the new input across action variants. The main gaps are around fail-closed ergonomics: fail mode still retries deterministic model failures, and invalid fallback configuration is only validated on the disallowed-model path. |
Keep model selection unchanged and reuse existing error classifiers and retry handling. Reject blocked or invalid models without substituting another model when model_policy_fallback is fail. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
l30t
force-pushed
the
leo/fail-closed-model
branch
from
October 10, 2026 21:31
0b559cd to
c372298
Compare
Generalize the input name across all actions, preparation and execution, tests, and documentation without changing fallback behavior. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflows that require their requested model can opt into
model_fallback: fail. Today the Action may replace a blocked or invalid model with a concrete tier-alias stand-in or the organization's default model. Fail mode stops instead, while leaving model selection and the default fallback behavior unchanged.Scope and impact
This is independent Action hardening, not a prerequisite for CLI-2122 or Sonnet 4 retirement. The default remains
organization-default; existing workflows do not opt into strict mode automatically.No changes to security or validator model selection, reasoning settings, debug artifact names, CLI policy enforcement, or GitLab component inputs. In fail mode, an older CLI that rejects a tier alias fails instead of using the concrete-model compatibility fallback. Tier aliases still resolve in the CLI, and a failed policy lookup still defers enforcement to the CLI/server.
Testing
Validated on
33026ce:bun test: 754 passed, 0 failed.bun run typecheck: passed.bun run format:check: passed.actionlint .github/workflows/*.yml: passed.