Repository navigation
Merge dev into main: review presets use model tier aliases - #145
Merged
Merged
Conversation
Review presets now use Factory model tier aliases (deep: openai-latest-balanced, shallow: oss-latest-balanced) so reviews follow the current recommended model without a droid-action release or a workflow edit. Tier aliases skip the client-side policy pre-check (the CLI enforces policy on the resolved model), and a CLI-side policy rejection now triggers the existing retry-without-model fallback. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Docs, the GitLab template, and action input descriptions now recommend review_depth as the only model setting. Model override inputs move to a collapsed "Advanced: Model Overrides" section that lists only tier aliases, and the list of concrete model IDs is removed. Model fallback hints point back to the default instead of the full model list. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
feat(review): default review presets to model tier aliases
factory-nizar
marked this pull request as ready for review
September 28, 2026 20:25
Contributor
|
Droid finished @factory-nizar's task —— View job Note The requested model is not a recognized model id, so Droid retried with your organization's default model. Remove the model input (e.g. No inline comments were approved because the supplied PR diff is empty. The candidate describes a real standalone security-action configuration mismatch, but its line anchor is not postable. 0 inline comments posted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
devtomainfor thev9release. Clean merge (git merge-treereports no conflicts; every non-merge commit onmainis already indev).Important
Do not merge until the Droid CLI release that includes Factory-AI/factory-mono#22502 is live. The new presets pass
--model openai-latest-balanced/oss-latest-balanced, and today's production CLI does not know those aliases yet. On an older CLI,droid execfails withInvalid model, and the action retries with the org's default model and posts a confusing "not a recognized model id" note on the PR. The factory-mono PR merged todevon 2026-09-26; as of 2026-09-28 it is not onmainyet. To check before merging, rundroid exec --model openai-latest-balanced "hi"on the latest CLI.Included
deepnow usesopenai-latest-balancedwith high reasoning. It resolves to GPT-5.6 Sol today (same as the current default) and moves to GPT-6 Sol once that model is generally available.shallownow usesoss-latest-balanced(GLM-5.3; previously pinned to GLM-5.2).Model blocked by organization policyfrom the CLI now triggers the existing retry-without---modelfallback.review_depth. Model overrides moved to an "Advanced: model overrides" section that lists all 9 tier aliases.After merge
Create the
v9GitHub release onmain(v8is at #143).