Repository navigation
Prevent use-after free if memory pool is disposed - #738
Merged
adamreeve merged 1 commit intoNov 4, 2026
Merged
Conversation
Add references to the ProxyMemoryPool handle to keep it alive even if disposed, as long as it's still used by a ParquetFileWriter.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the proxy memory pool lifetime changes.
No open issues 🎉
What changed in this PR
This follow-up to #736 protects native proxy memory pools from premature release when disposed while still used by Parquet objects.
Changes:
- Add native-handle leases so dependent objects keep proxy pools alive until freed.
- Track explicit disposal separately to reject new direct uses of a disposed pool.
- Add regression tests for disposing pools while writers, builders, and readers remain in use.
| File | Description |
|---|---|
csharp/WriterPropertiesBuilder.cs |
Acquire and release pool leases as the builder’s pool changes or the builder is freed. |
csharp/ProxyMemoryPool.cs |
Implement handle leases, track disposal, and clarify lifetime guarantees. |
csharp/MemoryPool.cs |
Add lease hooks and use them in native-object cleanup callbacks. |
csharp.test/TestProxyMemoryPool.cs |
Test continued writer, builder, and reader use after pool disposal. |
Review effort: Balanced
adamreeve
marked this pull request as ready for review
November 4, 2026 09:07
marcin-krystianc
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #736
Add references to the ProxyMemoryPool handle to keep it alive even if disposed, as long as it's still used by a ParquetFileWriter.