Repository navigation
Fix SGDimensionMap save file name being invalid on Windows - #30
Merged
Merged
Conversation
UltraProdigy
approved these changes
Oct 30, 2026
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While trying to startup a local dedicated to test a dev on a gate world from someone else I ran into that error being very semi spammed in the logs.
This is a fix for that , plus also a bump of deps and buildscript since it haven't been done in a while.
Full Explanation
The dimension map was saved as "sgcraft:dimension_map.dat", and ":" isn't a valid filename character on Windows.
java.io.Filewrites it as a hidden NTFS alternate data stream on an empty "sgcraft" file. This works, but the data is lost when the world is zipped or copied to another machine.WorldDataSaverusesFile.toPath(), which rejects the ":", so every save fails withInvalidPathException.sgcraft_dimension_map.dat. SGCraft never reads that file and starts an empty map, which can break stargate addresses.Fix
sgcraft_dimension_map.datinstead.sgcraft:dimension_map.datonce and save it under the new name. This covers both Linux files and Windows hidden streams. The old file is left in place.Checklist