Repository navigation
fix(runtime): preserve committed mutation effects and honor hook configuration - #261
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes that took longer than five seconds could return 500 even though storage later committed them. Post-commit hooks, audit events, and webhook dispatch also depended on the HTTP handler staying alive. Mutation replies now wait for the storage outcome, and actor-owned completion runs these effects after a commit, including after the client disconnects. Lost replies return 504
mutation_outcome_unknownwith reconciliation guidance.The gRPC dispatcher now honors the configured default timeout, and background hooks enforce
max_concurrent_async. Hook queue admission happens before mutation submission so a full hook mailbox cannot block ForgeActor completion. Runtime webhook subscription lookup uses storage directly to avoid calling back into the committing actor.Prepare patch release v0.52.4, with runtime crate v0.50.3, changelog, and operating notes.
Validation:
Fixes #259
Fixes #260