Conversation
Owner
|
already fixed in PR #81 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t3d_fog_set_rangedoubles the offset and halves the scale. Both ends of therange land at twice the value passed in.
tiny3d/src/t3d/t3d.c
Lines 568 to 569 in 73d822f
Cause
Ucode computes
(clipZ + offset) * scaleand subtracts that from a full s16.Zero fog needs
clipZ == near, full fog needs the product to reach 32767. Thatgives
offset = -nearandscale = 32768 / (far - near).Current code halves one and doubles the other:
Zero fog then lands at
clipZ == 2*near, and saturation at2*far.Magma, in libdragon, runs the same computation on the same clip-space Z with
neither factor:
Measurement
Four posts on one axis, 10 metres apart, FPS camera walking the line, both fog
distances printed on screen. Range set to 0-25 metres, fog saturates at 50.
Screenshots of both builds attached, before and after the fix. Both ROMs are
attached as well.
Fix
Impact
Behaviour change, visible in every existing project. Every declared fog range
changes meaning, including the ones under
examples/.