Repository navigation
Fix user feedbacks - #251
NikhitaR-IFX wants to merge 6 commits into
Conversation
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
jaenrig-ifx
left a comment
There was a problem hiding this comment.
I don't the need of redundant comments (literally repeating what the signature already clearly states) in the snippets. To me, they create clutter and noise.
But I let that to @ederjc.
The rest looking good! 👍
Please point out to which part of the PR you're referring. |
Such comment does not really add any additional information which the code does not provide itself. Comments that could provide some additional info:
Also, the pins are not really exclusive for the CY8CPROTO-062-4343W, but many of them make sense for that board, because they are exposed only in that board . |
ederjc
left a comment
There was a problem hiding this comment.
In my perception the "redundant" comments have been there before and Nikhita made them appear more consistently.
Fine for me, rather we document a bit more then too little. This is also targeting beginners, which might benefit from that.
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
|
The build failure is not related to docs itself but mbedtls version (as discussed). Let me know if I should bypass rules and merge or we need to keep it on hold until resolved? |
Summary
Generative AI
I did not use generative AI tools when creating this PR..