Skip to content

Remove cluster hooks in favour of pg_dumpall -g #48

Description

@JAForbes

We've got an always hook that runs always, but after the transaction. But maybe we should rename it to post and have a pre hook. Both hooks would always run and could be used to create roles using a declarative util.

I want to remove the cluster hooks concept (see #46). Hostname isn't a good property to rely on to detect change.

We also tend to configure our local env so the production db url is the same as the local db url within a docker container. So relying on the hostname in the db url isn't great either.

I also considered having a top level export for roles, but we would need to diff them to see if properties change and that mixes metaphors because pgmg is declarative, so having a single declarative hook feels like it could cause confusion and lead to surprise if it does or doesn't respond to change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions