Repository navigation
fix(eks): resolve colleague E2E deployment blockers across cluster lifecycle, STS auth, and secrets - #7
Merged
Conversation
…fecycle, STS auth, and secrets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the root causes identified during the colleague fresh-appliance E2E AWS EKS BNK 2.4.1 deployment:
SecretsService.prepare_secrets_for_execution: Exposesfilesecrets whosenameortarget_variable_nameiscne_pull_secretorjwt_tokeninvalue_secrets(in addition tofile_secrets), and normalizes raw JSON pull secrets to base64 and unwrapped JWT tokens.KubernetesEngine._helm_registry_login: Accepts both raw JSON ({...}) and base64-encodedcne_pull_secretvalues for Docker config JSON and GCP service account JSON keys.VariableAssembler.build_variables: Adds Layer 6b fallback to recovercne_pull_secret/jwt_tokenfromproject_variables['variable_defaults']or sibling project modules when missing on a downstream Kubernetes module.services/eks_service.py: Extracts region fromeks_cluster_arn/cluster_arnARN prior to falling back toproject.regionorvariable_defaults; generates kubeconfig before looking up existing rows; upserts existingKubernetesClusterrows in-place and prunes stale auto-registered rows in the same project; updatesunregister_eks_clusterto match bysource_module_id,cluster_nameoutput, or auto-registered project cluster.tasks/opentofu_tasks.py: Snapshotsprev_outputsbefore clearing module outputs on destroy and triggersunregister_eks_clusterfor any EKS cluster module (_classify_managed_cluster_module == 'eks'ormatches_eks_output_contract(prev_outputs)).EngineRouter: Self-heals missing, stale, or duplicateKubernetesClusterrows inresolve_contextandresolve_kubeconfigwhen an applied project module satisfies the EKS output contract._inject_eks_bearer_tokenRegion Priority & Credential Fallback):cluster.regionovercreds_env.get('AWS_REGION')when signing STS presigned bearer tokens and falls back toproject_variables['variable_defaults']/ module overrides for AWS credentials when no credential template is bound.variable_defaultsFallbacks):generate_forge_kubeconfig_localandwrite_provider_configfall back toproject.project_variables['variable_defaults']forcluster_name/eks_cluster_nameandaws_region/region.dist/docker-compose.ymlVolume Sync):provider_cache,bfb_cache,./certs:/app/certs:ro, andTF_PLUGIN_CACHE_DIRintodist/docker-compose.yml.Verification
backend/tests/component/test_eks_e2e_colleague_fixes.py.pytestacross unit & component suites andscripts/tests/ibm-compose-drift.test.sh+deploy-version-lockstep.test.sh.