Repository navigation
perf(ios): reuse verified screens after number taps - #606
Open
JosssphZhou wants to merge 2 commits into
Open
JosssphZhou wants to merge 2 commits into
JosssphZhou wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Start reading immediately after a single number-key tap when the current screen has an identifiable numeric display. Reuse the first verified screenshot after a second tree confirms the same app, layout, and value.
If the observation remains unconfirmed, read again without repeating the tap. When a fresh screenshot is unavailable, omit the cached image from the action reply.
Motivation
A fixed pause delayed each screen read even when the display had already updated.
Test plan
Screenshots or screen recording
The simulator capture shows 7 in the display above the separate 7 key. The captured image and each sample are in the acceptance evidence.
AI assistance: Codex. I have reviewed and understand these changes.