Repository navigation
fix(ios): restore 0.4.5 Poki status card and inline model and approval dropdowns - #612
Open
JosssphZhou wants to merge 1 commit into
Open
JosssphZhou wants to merge 1 commit into
JosssphZhou wants to merge 1 commit into
Conversation
…downs Replace the native SwiftUI status menu with the 0.4.5 PokiStatusCard overlay and its inline expanding Model and Approval Method dropdowns so tapping Poki opens the card cleanly below the avatar without covering it. Preserve 0.4.6 and 0.4.7 behavior inside the card: - Group multiple custom providers under their display names in the inline Model dropdown. - Keep Automatic Unlock hidden while unavailable in the 0.4.7 candidate. - Keep the Customize Poki row in the card and direct avatar tap in chat.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
app-0.4.5-prealpha.1770PokiStatusCardcomponent, overlay positioning (top = under + 12pton Home,84ptunder the top bar in Chat/Voice), spring presentation, frosted card styling, and inline expanding Model and Approval Method dropdowns.PokiMenuso there is a single status panel implementation across the Home avatar, Chat name pill, and Voice header.PokiStatusCard:model.supportsAutoUnlock).PokiHead's accessibility container sochat.header.detailskeeps its own 24 pt pill bounds separate fromchat.header.avatar.PokiStatusCardTestscovering inline approval switching, hidden Automatic Unlock, Customize Poki dismissal/navigation, and inline custom-provider model switching.Motivation (Closes #N)
The native SwiftUI
Menuintroduced in #580 and retained in #596 popped over the status area and used nested system menus for Model and Approval Method instead of expanding cleanly below Poki's avatar. Restoring the 0.4.5PokiStatusCardbrings back non-occluding placement and inline dropdown expansion.Test plan
xcodebuild build-for-testingon iPhone 17 Pro Simulator, iOS 27.0) and baselineapp-0.4.5-prealpha.1770simulator app.PokiStatusCardTests(2 tests, 0 failures) andApprovalsPageTests(1 test, 0 failures) on iPhone 17 Pro Simulator.app-0.4.5-prealpha.1770and the updated 0.4.7 candidate side by side on iPhone 17 Pro Simulator (Home status card open, Model inline dropdown open, Approval Method inline dropdown open, Chat header pill open) and verified the interactive flow via simulator screen recording.Screenshots or screen recording
Verified side by side on iPhone 17 Pro Simulator against
app-0.4.5-prealpha.1770(status panel below the Home avatar, inline Model dropdown, inline Approval Method dropdown, and full interactive screen recording).AI assistance: Other. I have reviewed and understand these changes.