Skip to content

fix(ios): restore 0.4.5 Poki status card and inline model and approval dropdowns - #612

Open
JosssphZhou wants to merge 1 commit into
test/047-candidate-2from
fix/esp-1199-restore-avatar-panel
Open

JosssphZhou wants to merge 1 commit into
test/047-candidate-2from
fix/esp-1199-restore-avatar-panel

Conversation

@JosssphZhou

Copy link
Copy Markdown
Owner

Summary of changes

  • Restore the app-0.4.5-prealpha.1770 PokiStatusCard component, overlay positioning (top = under + 12pt on Home, 84pt under the top bar in Chat/Voice), spring presentation, frosted card styling, and inline expanding Model and Approval Method dropdowns.
  • Remove the native SwiftUI PokiMenu so there is a single status panel implementation across the Home avatar, Chat name pill, and Voice header.
  • Preserve 0.4.6 and 0.4.7 additions inside PokiStatusCard:
    • Multiple custom providers grouped under their display names in the inline Model dropdown.
    • Automatic Unlock kept hidden while unavailable in the 0.4.7 candidate (model.supportsAutoUnlock).
    • Customize Poki row at the bottom of the card (and direct Chat avatar tap to open the unified customization page), while fixing PokiHead's accessibility container so chat.header.details keeps its own 24 pt pill bounds separate from chat.header.avatar.
  • Add PokiStatusCardTests covering inline approval switching, hidden Automatic Unlock, Customize Poki dismissal/navigation, and inline custom-provider model switching.

Motivation (Closes #N)

The native SwiftUI Menu introduced in #580 and retained in #596 popped over the status area and used nested system menus for Model and Approval Method instead of expanding cleanly below Poki's avatar. Restoring the 0.4.5 PokiStatusCard brings back non-occluding placement and inline dropdown expansion.

Test plan

  • Built Debug simulator app and test bundle (xcodebuild build-for-testing on iPhone 17 Pro Simulator, iOS 27.0) and baseline app-0.4.5-prealpha.1770 simulator app.
  • Ran PokiStatusCardTests (2 tests, 0 failures) and ApprovalsPageTests (1 test, 0 failures) on iPhone 17 Pro Simulator.
  • Visually compared app-0.4.5-prealpha.1770 and the updated 0.4.7 candidate side by side on iPhone 17 Pro Simulator (Home status card open, Model inline dropdown open, Approval Method inline dropdown open, Chat header pill open) and verified the interactive flow via simulator screen recording.
  • Physical iPhone verification not run in this change.

Screenshots or screen recording

Verified side by side on iPhone 17 Pro Simulator against app-0.4.5-prealpha.1770 (status panel below the Home avatar, inline Model dropdown, inline Approval Method dropdown, and full interactive screen recording).

AI assistance: Other. I have reviewed and understand these changes.

…downs

Replace the native SwiftUI status menu with the 0.4.5 PokiStatusCard
overlay and its inline expanding Model and Approval Method dropdowns so
tapping Poki opens the card cleanly below the avatar without covering it.

Preserve 0.4.6 and 0.4.7 behavior inside the card:
- Group multiple custom providers under their display names in the inline
  Model dropdown.
- Keep Automatic Unlock hidden while unavailable in the 0.4.7 candidate.
- Keep the Customize Poki row in the card and direct avatar tap in chat.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant