fix(settings): normalize file-only ACL flags - #31
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b70e9ae130
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| windows-tests: | ||
| runs-on: windows-latest |
There was a problem hiding this comment.
Gate package publishing on the Windows test job
On pushes to master, this newly added job runs independently of the existing build job, whose final steps publish the package to NuGet and GitHub. Because jobs without a needs relationship run in parallel, version 8.1.2 can be published before these Windows-only tests finish—and remains published even if they fail—so the new coverage does not protect releases of the Windows-only atomic-write path. Move publishing into a job that depends on both test jobs, or otherwise make publishing wait for windows-tests.
Useful? React with 👍 / 👎.
| <RepositoryUrl>https://github.com/Kibnet/WritableJsonConfiguration</RepositoryUrl> | ||
| <PackageProjectUrl>https://github.com/Kibnet/WritableJsonConfiguration</PackageProjectUrl> | ||
| <PackageVersion>8.1.1</PackageVersion> | ||
| <PackageVersion>8.1.2</PackageVersion> |
There was a problem hiding this comment.
Update the release metadata for version 8.1.2
When this version is packed and published, PackageReleaseNotes still describes the 8.1.1 numeric-path fix, and CHANGELOG.md still ends at 8.1.1. Consequently package consumers see no mention of the ACL-normalization change that actually distinguishes 8.1.2. Update the package release notes and changelog alongside this version bump.
Useful? React with 👍 / 👎.
Summary
File.Replace.InheritOnlyremain significant.Changes
ObjectInherit,ContainerInheritandNoPropagateInheritwhen comparing ACEs for a file; these flags only control propagation to child objects, and a file cannot have children.InheritOnlycase.Validation
WritableJsonConfiguration.8.1.2.nupkgcreated successfully.Risks / Rollback
InheritOnlyis deliberately not ignored.Links