Skip to content

fix: surface auth reply errors instead of swallowing them #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuzzlor merged 3 commits into from
May 21, 2026
Merged

fix: surface auth reply errors instead of swallowing them #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
272ab46
fix: handle the auth reply URL having error state (currently swallowed)
cuzzlor May 21, 2026
d0b2f5b
adjust
cuzzlor May 21, 2026
643c1c7
npm audit fix
cuzzlor May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@makerx/express-msal",
"version": "2.0.0",
"version": "2.0.1",
"private": false,
"description": "An express middleware for PKCE via Microsoft Authentication Library for Node (MSAL Node).",
"author": "MakerX",
Expand Down
6 changes: 6 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ const createAuthHandler = ({ msalClient, scopes, authReplyRoute, augmentSession,
pkceCodes: { verifier },
} = req.session

if (req.query.error) {
const details = { error: req.query.error, error_description: req.query.error_description }
logger?.error('Error returned in auth reply query parameters', details)
throw new Error(req.query.error as string, { cause: details })
}

const tokenRequest: AuthorizationCodeRequest = {
code: req.query.code as string,
scopes,
Expand Down