Repository navigation
Add penalties testcases - #6
VictorYanson wants to merge 3 commits into
Conversation
|
Before merging: Would it be fitting to place the |
| * @return The gap extension penalty if the gap type is dual affine. | ||
| * Otherwise, return 0. | ||
| */ | ||
| penalty_t gape2() const { return gape_; } |
There was a problem hiding this comment.
Let me know if this was intentional, if so, I’ll change it back
| tests/interactive/* | ||
|
|
||
| # Apple-specific | ||
| .DS_Store |
There was a problem hiding this comment.
Just an annoying Apple thing
| TEST_CASE("Check penalty members") { | ||
| SUBCASE("Linear") { | ||
| theseus::Penalties penalties(0, 1, 1); | ||
| CHECK(penalties.type() == theseus::Penalties::Linear); |
There was a problem hiding this comment.
Is there a reason you always use CHECK assertions instead of the built in CHECK_EQUAL? Just curious
|
@albertjimenezbl let me know if this PR works for you. I'd love to contribute more, just wanna get this one done to understand if this kind of approach is what you're looking for |
PR adds doctest test cases for
penalties.h. I tried to approximately mimic the unit test structure for the other existing modules. Let me know if anything needs to be improved!Summary
Check penalty memberstest case goes through all three penalty types and asserts expected member function outputs.Note: I asked AI what argument values to pass to each penalty type. Beyond that, everything was handwritten.