Repository navigation
Harden memory-safety and RPC boundary handling in core C paths (excluding workflow @latest) - #303
Merged
Merged
Conversation
…test) Agent-Logs-Url: https://github.com/MechaResearch/MechaPwn/sessions/742738f4-4f65-4fa4-8216-20e7379e9740 Co-authored-by: AKuHAK <621640+AKuHAK@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MechaResearch/MechaPwn/sessions/742738f4-4f65-4fa4-8216-20e7379e9740 Co-authored-by: AKuHAK <621640+AKuHAK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses unsafe code paths flagged during security review, focusing on memory-safety and trust-boundary handling in runtime C code. Workflow
@latestusage was intentionally left unchanged per scope.String formatting hardening
vsprintf→vsnprintfin UI text formattingsprintf→snprintffor NVRAM backup path and model/color string writesRPC boundary and buffer safety
MechaScmdHeader) for:inputlengthvaluesMechaScmd) to validate both input and output lengths and copy only caller-requested output size.Allocation failure handling in rendering paths
malloc/memalignin texture creation code.Pointer lifecycle cleanup fixes
ROMVER read safety