Fix legacy Codec compatibility on Forge 1.12.2 - #299
Merged
SkyBlade1978 merged 2 commits intoSep 9, 2026
Merged
Conversation
SkyBlade1978
merged commit Sep 9, 2026
8315da4
into
MinecraftModDevelopmentMods:master-1.12.2
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.mojang.serialization.CodecadapterCodecsupplied earlier on a legacy modpack classpathStandardPatternSettings.CODEC,OrePatternType.create(Codec, Function),OrePatternType.codec(), API major 1, schemas 4/6/5, profiles, migrations, registries, and world-generation behavior4.0.17.112021noguiargument and rejects--noguiThis is deliberately a Forge 1.12.2 compatibility release. Cleanroom targets Minecraft 1.12.2, and no other OreSpawn branch will receive the bridge without target-native evidence of the same class/interface collision.
Validation
4.0.17.112021candidate boots their Cleanroom client and connects to their serverIncompatibleClassChangeErrorand passes on 4.0.17noguiCodecsourceIncompatibleClassChangeError,NoSuchMethodError,AbstractMethodError, orClassCastException; zero crash reports or surviving test processesFMLAT, both access-transformer rules, documentation/locales, and zero fixture/test/world leakageExact main jar SHA-256:
DA99AC45B663E0FB582AC175E7D5AC53C962BD03F00E79299C4BE0E33E9DCCF2Addresses #298.