Repository navigation
feat(classifier): add judge image input controls - #790
Open
ayushag-nv wants to merge 7 commits into
Open
ayushag-nv wants to merge 7 commits into
ayushag-nv wants to merge 7 commits into
Conversation
|
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
ayushag-nv
force-pushed
the
ayushag/judge-vision-routing-support
branch
from
October 9, 2026 18:18
06c0325 to
b3ba06b
Compare
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
ayushag-nv
marked this pull request as ready for review
October 9, 2026 22:32
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Capability and custom classifiers already forward images to the judge. They need a separate image limit so a text-only judge, or a judge using fewer images, can select an answer model that still receives the original request.
Tracks SWITCH-1542.
What
judge_max_imagesto classifier configuration, TOML routes, and Python bindings. Unset keeps all selected images;0omits them;Nkeeps the newest N in their original order.How
Apply the limit after message selection and before copying image payloads. Replace omitted images with text markers so image-only messages remain valid. Escalation mode rejects this setting. This change does not fetch, resize, or decode media.
Where to Start Review
Start with
TaskInput::messagesandcopy_judge_blockincrates/libsy/src/algorithms/llm_class.rs, then the runner and Python configuration wiring. The server testclassifier_image_limits_preserve_answer_imagescovers the judge and answer requests together.Test Plan
These checks cover request handling and routing behavior; they do not measure judge accuracy.
Summary by CodeRabbit
New Features
0excludes images.Bug Fixes