ci(release): advance seeded prereleases daily at Zurich time - #3239
Open
SDAChess wants to merge 1 commit into
Open
ci(release): advance seeded prereleases daily at Zurich time#3239SDAChess wants to merge 1 commit into
SDAChess wants to merge 1 commit into
Conversation
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 9, 2026 14:29
elezar
reviewed
Sep 10, 2026
Member
There was a problem hiding this comment.
Does that mean that this workflow is no longer used by other mechanisms?
elezar
reviewed
Sep 10, 2026
| exit 0 | ||
| fi | ||
| if ! git merge-base --is-ancestor "$latest" HEAD; then | ||
| echo "::error::Latest pre-release $latest is not an ancestor of main" |
Member
There was a problem hiding this comment.
nit: are we always running on main?
elezar
reviewed
Sep 10, 2026
Comment on lines
+82
to
+83
| env: | ||
| NEXT_TAG: ${{ steps.version.outputs.next }} |
Member
There was a problem hiding this comment.
nit: Is there a reason to switch to an env here? (It introduces an unneeded diff).
elezar
reviewed
Sep 10, 2026
Comment on lines
+450
to
+454
| Maintainers choose the next version by creating `vX.Y.Z-pre.1`. The workflow | ||
| increments the highest release series' pre-release number on `main` only when | ||
| that seed exists, its stable tag does not exist, and new commits are available. | ||
| It never chooses a minor or patch version or creates the initial seed. After | ||
| pushing the tag, it explicitly dispatches `release-tag.yml` to build the candidate. |
Member
There was a problem hiding this comment.
What about something like: "Maintainers trigger daily pre-release releases by tagging the initial vX.Y.Z-pre.1 release candidate"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Advance an explicitly seeded pre-release series daily at 16:00 Europe/Zurich, including daylight saving changes. Without a matching
vX.Y.Z-pre.1, the workflow creates no tag and never guesses whether the next release is a minor or patch.Related Issue
No issue required: localized maintenance of the existing release auto-tag workflow, replacing automatic patch selection with maintainer-seeded pre-release increments.
Changes
main.Testing
git diff --checkpasses.mise run pre-commitandmise run cicould not start because mise is not installed. Pre-commit was explicitly waived by the requester.Checklist