fix(install): avoid installing incompatible docker snap - #3666
Merged
krishicks merged 4 commits intoSep 24, 2026
Merged
Conversation
The work to land RFC-0012 added new restrictions when interacting with Docker by setting `NoNewPrivs`. This prevents the `docker` snap from transitioning its AppArmor profile from `snap.docker.dockerd` to `docker-default` when it tries to launch a container. Thus, the `docker` snap is currently incompatible with OpenShell. This commit prevents `install.sh` from installing the `docker` snap before installing the `openshell` snap, and instead requires the user to install a non-snap Docker daemon before proceeding with installing the snap. Systems without the `snap` command are unaffected, since they install native packages without checking for the presence of Docker or other compute providers. Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
olivercalder
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 24, 2026 16:59
krishicks
reviewed
Sep 24, 2026
olivercalder
commented
Sep 24, 2026
olivercalder
left a comment
olivercalder
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for the review
Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
Collaborator
|
/ok to test 7f8424d |
krishicks
reviewed
Sep 24, 2026
…alls work Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
Collaborator
|
/ok to test 7f8424d |
@krishicks, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Collaborator
|
/ok to test 05a42b8 |
krishicks
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The work to land RFC-0012 added new restrictions when interacting with Docker by setting
NoNewPrivs. This prevents thedockersnap from transitioning its AppArmor profile fromsnap.docker.dockerdtodocker-defaultwhen it tries to launch a container. Thus, thedockersnap is currently incompatible with OpenShell.This commit prevents
install.shfrom installing thedockersnap before installing theopenshellsnap, and instead requires the user to install a non-snap Docker daemon before proceeding with installing the snap. Systems without thesnapcommand are unaffected, since they install native packages without checking for the presence of Docker or other compute providers.Related Issue
Fixes recently-landed changes in #3656, with
NoNewPrivsintroduced in #2942.Changes
dockersnap when installing theopenshellsnapdockeris not present or thedockersnap is present, and ask the user to install a non-snap Docker daemonTesting
mise run pre-commitpassesChecklist