Skip to content

[Core] Fix PredicateVector zero detection - #3577

Open
migarci2 wants to merge 1 commit into
NVIDIA:mainfrom
migarci2:fix/predicate-vector-last-word
Open

migarci2 wants to merge 1 commit into
NVIDIA:mainfrom
migarci2:fix/predicate-vector-last-word

Conversation

@migarci2

@migarci2 migarci2 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep complete predicate masks instead of narrowing them to bool
  • include every byte when the last storage word is exactly full
  • cover single-word, partial-word, full-word, and padding-bit cases

Testing

  • compiled test/unit/core/predicate_vector.cu with NVCC 11.2
  • ran PredicateVector.* on an RTX 3090: 3 tests passed
  • verified the standalone reproduction fails before the change and passes after it
  • git diff --check

The machine has CUDA 11.2, so the unrelated complex.cu part of the aggregate core target cannot build against CUTLASS 4.8. The affected test source compiled and ran successfully.

Contribution disclosure

AI assistance was used for repository research, implementation, independent review, and running the checks above.

Fixes #3512

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PredicateVector::is_zero ignores the last storage word when kBytes is a multiple of sizeof(Storage)

1 participant