Repository navigation
Leave zero argument bool alone in the CuTeDSL preprocessor - #3590
Closed
Hashim1999164 wants to merge 1 commit into
Closed
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Author
|
yo looks like this already landed on main (and #3506 is closed for 4.8). the preprocessor now only rewrites the one arg bool form and leaves bool() alone. gonna close this one out since theres nothing left to ship here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged bool() has no args so the preprocessor indexed args[0] and raised IndexError.
Only redirect bool when there is exactly one positional argument. Zero argument and keyword forms stay as bool so Python can raise TypeError.
Closes #3506
Test plan
Run test/python/CuTeDSL/test_bool_zero_args.py with the CuTeDSL package available.