Repository navigation
Preserve active GQA mailbox contributions during initialization - #3601
Open
1sgtpepper wants to merge 3 commits into
Open
1sgtpepper wants to merge 3 commits into
1sgtpepper wants to merge 3 commits into
Conversation
Signed-off-by: 1sgtpepper <cynejarviszarceno@gmail.com>
Signed-off-by: 1sgtpepper <cynejarviszarceno@gmail.com>
Signed-off-by: 1sgtpepper <cynejarviszarceno@gmail.com>
|
This PR has been labeled |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3598.
Initialize only inactive split mailboxes in
EPILOG_warp. Active producers may already have written their contributions when a receiving CTA reaches initialization; clearing those entries can erase valid data. Existing transaction waits order producer completion before reduction. Inactive entries retain their required −infinity/zero/zero values.The shared epilog serves both contiguous and paged GQA.
Tests
Build
93_blackwell_low_latency_gqa_mailboxeswithCUTLASS_NVCC_ARCHS=100a, then run:On B200/CUDA 13.1.1, all-active, one-active and partial-tail cases pass numerically with zero racecheck hazards. Restoring the original header produces 54 wrong values; counts vary with scheduling. CMake build.
Each active split processes one tile, isolating this regression from the scratch-reuse race in #3600. With both fixes, the contiguous and paged example checks pass. Another 16 contiguous regression cases pass under racecheck and memcheck.