Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cute/algorithm/copy.hpp and cute/algorithm/prefetch.hpp both include cute/atom/copy_atom.hpp to pull in Copy_Atom, TiledCopy, and ThrCopy. However, copy_atom.hpp includes
these algorithm headers back through a cycle:
copy_atom.hpp -> mma_atom.hpp -> ... -> partitioner.hpp -> tensor.hpp -> (back here)
Because of this cycle, a translation unit whose first cute include is copy_atom.hpp parses the overloads in copy.hpp/prefetch.hpp while their own #include
<cute/atom/copy_atom.hpp> is a no-op (the include guard is already active). The dispatch types are therefore not yet declared, and the overloads fail to parse.
Fix
Add forward declarations of the atom class templates at the top of each header, so the overloads that dispatch on them remain valid regardless of include order. The full
definitions still arrive from copy_atom.hpp before anything can instantiate them.
Impact