Repository navigation
[DOC] Improve trial_shifting parameter documentation - #704
Open
CozySocksAlways wants to merge 2 commits into
Open
CozySocksAlways wants to merge 2 commits into
CozySocksAlways wants to merge 2 commits into
Conversation
CozySocksAlways
marked this pull request as ready for review
June 17, 2026 14:08
Collaborator
CozySocksAlways
commented
Jun 29, 2026
kohlerca
reviewed
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ditherparameter oftrial_shiftingworks and makes the code match the documented behaviour.ditherChanges
trial_shifting,_trial_shifting_of_concatenated_spiketrain): theditherentry now says that all spikes in a trial are shifted by the same random amount, drawn uniformly from the closed interval[-dither, +dither]._trial_shifting): the shift is now drawn withrandom.uniform(-dither, dither)instead ofdither * (2 * random.random() - 1). This also matches the intent mentioned in the documentation and also reads better in code. The behavior is unchanged, so the distribution is same.